Allow declaration of external dependencies for YAML UDFs.#34073
Allow declaration of external dependencies for YAML UDFs.#34073robertwb merged 5 commits intoapache:masterfrom
Conversation
|
R: @derrickaw |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
robertwb
force-pushed
the
yaml-deps
branch
2 times, most recently
from
d2018e7 to
cdb24de
Compare
| return super().requires_inputs(typ, args) | ||
|
|
||
| def _with_extra_dependencies(self, dependencies): | ||
| external_provider = ExternalPythonProvider( # |
There was a problem hiding this comment.
| external_provider = ExternalPythonProvider( # | |
| external_provider = ExternalPythonProvider( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34073 +/- ##
=========================================
Coverage 56.35% 56.35%
Complexity 3286 3286
=========================================
Files 1173 1173
Lines 179087 179178 +91
Branches 3398 3398
=========================================
+ Hits 100928 100982 +54
- Misses 74904 74941 +37
Partials 3255 3255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I went ahead and skipped the test in the flaky environment, as it seems environmental. The other tests are pre-existing (and I'm seeing them in other PRs). |
2 participants
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.